Skip to content

Refactoring - #13

Open
solidnerd wants to merge 6 commits into
cptactionhank:masterfrom
solidnerd:refactoring
Open

Refactoring#13
solidnerd wants to merge 6 commits into
cptactionhank:masterfrom
solidnerd:refactoring

Conversation

@solidnerd

Copy link
Copy Markdown

Hey @cptactionhank ,

thanks for your work on this awesome image. I tried it out and it works directly out of the box. I did some refactoring to the Dockerfile this resulted in a smaller image size because the problem of your current Dockerfile is that you are trying to remove something for an another layer and this doesn't work. The netatalk image is your builded image from your current Dockerfile from master. I did some refactorings and now we got only 217.9 MB on my refactored image.

REPOSITORY               TAG                 IMAGE ID            CREATED             SIZE
netatalk-new             latest              2fca29ab7490        33 minutes ago      217.9 MB
netatalk                 latest              25253d84d2e5        2 hours ago         506.3 MB

WDYT ?

Signed-off-by: solidnerd <niclas@mietz.io>
Signed-off-by: solidnerd <niclas@mietz.io>
The behaviour before was two use 2 seprated layers and that didn’t work when you are trying to remove something from the layer below your current layer. Because every layer under your current layer is readonly.

Signed-off-by: solidnerd <niclas@mietz.io>
Signed-off-by: solidnerd <niclas@mietz.io>
Signed-off-by: solidnerd <niclas@mietz.io>
Signed-off-by: solidnerd <niclas@mietz.io>
@AGresvig

Copy link
Copy Markdown

Nice work!
Bump..

@solidnerd

Copy link
Copy Markdown
Author

Thanks :)

@utdrmac

utdrmac commented Dec 6, 2019

Copy link
Copy Markdown

Can't you get this even smaller by using multi-stage build and just copy the resulting compiled binary to a new image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants