[1005E]

[jvega190]

https://github.com/craftersoftware/craftercms-e/issues/1005

Summary by CodeRabbit

• Bug Fixes
  • Password fields now consistently enforce the maximum allowed password length across account management, login, and password reset flows.
  • Autocomplete is now applied correctly per field purpose (current-password vs new-password) during login and password reset.
  • Password visibility toggle behavior and the underlying input configuration are now more consistent across all password entry screens.

[coderabbitai]

Walkthrough

Password fields now use USER_PASSWORD_MAX_LENGTH through slotProps.htmlInput. PasswordTextField merges slot properties while preserving input references, visibility controls, and existing InputProps behavior.

Changes

Password input constraints

Layer / File(s)	Summary
PasswordTextField slot composition studio-ui/ui/app/src/components/PasswordTextField/PasswordTextField.tsx	PasswordTextField merges provided HTML input and input slot properties, preserves the ref, and composes the visibility adornment with InputProps.
Password field constraints studio-ui/ui/app/src/components/AccountManagement/AccountManagement.tsx, studio-ui/ui/app/src/components/LoginView/LoginView.tsx, studio-ui/ui/app/src/components/ResetPasswordDialog/ResetPasswordDialog.tsx	Account management and password reset fields enforce USER_PASSWORD_MAX_LENGTH; password fields set the appropriate autocomplete values through slotProps.htmlInput.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: jmendeza

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title is only an issue code and does not describe the change.	Replace it with a concise descriptive title that names the main change, such as password length limits and slotProps updates.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description check	✅ Passed	The description includes a ticket reference, which matches the repository template.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@studio-ui/ui/app/src/components/AccountManagement/AccountManagement.tsx`:
- Around line 283-285: Update the password input configurations in
AccountManagement to set autocomplete tokens: use current-password for the
current-password field and new-password for the confirmation field, including
the additional field referenced by the repeated location. Preserve the existing
maxLength slotProps.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 96aebe3d-c2bd-4923-aa07-1e748a577627

📥 Commits

Reviewing files that changed from the base of the PR and between d921262 and afc3285.

📒 Files selected for processing (4)

• studio-ui/ui/app/src/components/AccountManagement/AccountManagement.tsx
• studio-ui/ui/app/src/components/LoginView/LoginView.tsx
• studio-ui/ui/app/src/components/PasswordTextField/PasswordTextField.tsx
• studio-ui/ui/app/src/components/ResetPasswordDialog/ResetPasswordDialog.tsx

[jvega190]

@coderabbitai can you check if everything looks good? Please give it a final review before I hand over for human review

[coderabbitai]

@jvega190 I’ll perform a final comprehensive review of #8830, including the password-field behavior and the shared PasswordTextField prop composition.

✅ Action performed

Full review finished.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@studio-ui/ui/app/src/components/PasswordTextField/PasswordTextField.tsx`:
- Around line 72-87: Update PasswordTextField’s slotProps construction to
support callback-valued slotProps.htmlInput and slotProps.input by resolving and
preserving their returned props before applying overrides. Merge the existing
htmlInput ref with inputRef rather than replacing it, and retain
visibilityAdornment/InputProps behavior for the input slot.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c06b3657-5518-460a-bf47-319f96caa30b

📥 Commits

Reviewing files that changed from the base of the PR and between d921262 and 948d394.

📒 Files selected for processing (4)

• studio-ui/ui/app/src/components/AccountManagement/AccountManagement.tsx
• studio-ui/ui/app/src/components/LoginView/LoginView.tsx
• studio-ui/ui/app/src/components/PasswordTextField/PasswordTextField.tsx
• studio-ui/ui/app/src/components/ResetPasswordDialog/ResetPasswordDialog.tsx

[jvega190]

@coderabbitai can you check if everything looks good? Please give it a final review before I hand over for human review

[coderabbitai]

@jvega190 I’ll perform a final review of #8830, focusing on password-field behavior, accessibility/browser autocomplete semantics, and PasswordTextField prop composition before human handoff.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.