Skip to content

Fix cyclonedx configs with new version - #8836

Open
jmendeza wants to merge 1 commit into
craftersoftware:developfrom
jmendeza:feature/fix-cyclonedx
Open

Fix cyclonedx configs with new version#8836
jmendeza wants to merge 1 commit into
craftersoftware:developfrom
jmendeza:feature/fix-cyclonedx

Conversation

@jmendeza

@jmendeza jmendeza commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Fix cyclonedx configs with new version

Summary by CodeRabbit

  • Chores
    • Updated software bill of materials generation to use the current direct generation workflow.
    • BOM output is now consistently produced in JSON format at build/bom.json.
    • Preserved license information, serial numbers, and runtime test dependency exclusions.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Gradle BOM generation was migrated from the legacy CycloneDX task to cyclonedxDirectBom, with schema version 14 and JSON output written to build/bom.json.

Changes

BOM generation

Layer / File(s) Summary
Configure direct CycloneDX BOM generation
gradle/bom.gradle
The direct CycloneDX task now configures schema version VERSION_14, JSON output, retained license and serial settings, and bomGenerate dependency wiring.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is only a brief phrase and does not use the required template section. Add the required '### Ticket reference or the full description of what's in the PR' section and summarize the change.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly refers to the CycloneDX config update, even if it is somewhat broad.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@gradle/bom.gradle`:
- Line 26: Update the schemaVersion assignment in bom.gradle to use the
SchemaVersion.VERSION_14 enum instead of the string value, and import
org.cyclonedx.model.schema.SchemaVersion so the CycloneDX Gradle plugin 3.3.0
configuration remains valid.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 17a7fdf3-6b4f-4667-9185-492028dea984

📥 Commits

Reviewing files that changed from the base of the PR and between 1e1c4bb and 64300e4.

📒 Files selected for processing (1)
  • gradle/bom.gradle

Comment thread gradle/bom.gradle
@jmendeza
jmendeza marked this pull request as ready for review July 28, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant