-
Notifications
You must be signed in to change notification settings - Fork 10
[DRAFT] Add support for Doctrine 4 #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* reverts some changes and keeps some deprecations
4cdfaab
to
939399e
Compare
Hey, I think we need a patch for the pdo driver aswell. That's why it's failing. It's still in a draft stage aswell. It can get quite frustrating to get to all the changes introduced in dbal 3 and 4. 5 is around the corner aswell. |
@JulianMar Did you have a chance to come back to this? |
Sorry for the late reply. I probably have some time over Christmas to work on this. My Plan is to get it running with DBAL 4.0, this way it can easily be upgraded to Frameworks already using 4.0. |
@JulianMar Thank you the update. Don't forget to enjoy the holiday season too 😄 |
Summary of the changes / Why this is an improvement
Add PHPStan to help with moving from DBAL 2 to the current version. We can first fix up all the deprecations and move from there:
Issues:
The fetch Syntax is a bit different and some fetch modes are not supported anymore. FETCH_BOTH is not supported and I guess will not be supported. I don't know the usecase for this fetch mode maybe someone can enlighten me and tell me why it's needed? Maybe we don't even need it anymore.
See here.
Checklist