Skip to content

[DRAFT] Add support for Doctrine 4 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

JulianMar
Copy link
Contributor

@JulianMar JulianMar commented Sep 3, 2024

Summary of the changes / Why this is an improvement

Add PHPStan to help with moving from DBAL 2 to the current version. We can first fix up all the deprecations and move from there:

Issues:

The fetch Syntax is a bit different and some fetch modes are not supported anymore. FETCH_BOTH is not supported and I guess will not be supported. I don't know the usecase for this fetch mode maybe someone can enlighten me and tell me why it's needed? Maybe we don't even need it anymore.
See here.

Checklist

  • Link to issue this PR refers to (if applicable):
  • CLA is signed

@JulianMar JulianMar changed the title feat: add phpstand and fix level 0 feat: add phpstan and fix deprecations in dbal Sep 3, 2024
@JulianMar JulianMar marked this pull request as draft September 3, 2024 17:55
@cla-bot cla-bot bot added the cla-signed label Sep 26, 2024
@amotl
Copy link
Member

amotl commented Nov 4, 2024

Dear Julian,

apologies for the late reply. Your updates are much appreciated. Do you have any idea why CI fails on your patch?

With kind regards,
Andreas.

/cc @surister, @kneth

@JulianMar
Copy link
Contributor Author

Hey, I think we need a patch for the pdo driver aswell. That's why it's failing.

It's still in a draft stage aswell.

It can get quite frustrating to get to all the changes introduced in dbal 3 and 4. 5 is around the corner aswell.
I will try to get back to it in the next few days, and will report back to this MR.

@kneth
Copy link

kneth commented Dec 10, 2024

@JulianMar Did you have a chance to come back to this?

@JulianMar
Copy link
Contributor Author

Sorry for the late reply. I probably have some time over Christmas to work on this.

My Plan is to get it running with DBAL 4.0, this way it can easily be upgraded to Frameworks already using 4.0.
5 will probably be another headache to get it to work and the Frameworks are not ready for it yet and I found no date for the planed release.

@kneth
Copy link

kneth commented Dec 16, 2024

@JulianMar Thank you the update. Don't forget to enjoy the holiday season too 😄

@amotl amotl changed the title feat: add phpstan and fix deprecations in dbal [DRAFT] Add support for Doctrine 4 Feb 12, 2025
@amotl amotl added important Not a bug, still important. dependencies Something about dependencies. labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed dependencies Something about dependencies. help wanted important Not a bug, still important.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants