-
Couldn't load subscription status.
- Fork 1
Driver: Add page about Go #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request adds comprehensive Go driver documentation to CrateDB, introducing pgx, pq, and KSQL packages as connectivity options. It updates the main connect index page to include a new Go card and navigation entry, while creating dedicated documentation pages for each driver with usage examples, features, and cloud connection instructions. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (1)
🧰 Additional context used🪛 markdownlint-cli2 (0.18.1)docs/connect/go/pgx.md86-86: Bare URL used (MD034, no-bare-urls) 🔇 Additional comments (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a5568d4 to
8f7a983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to merge #415 before this PR can be merged
6e459e5 to
6e33ebd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
docs/connect/go/index.md
Outdated
| :::{rubric} About | ||
| ::: | ||
|
|
||
| [pgx] is a pure Go driver and toolkit for PostgreSQL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just discovered lib/pq, a pure Go PostgreSQL driver for database/sql.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0c1d156 adds information about it. /cc @coderabbitai
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Show the commit details for 0c1d156b9c
git show 0c1d156b9c
Length of output: 2003
@amotl, thanks for the heads up! I've reviewed commit 0c1d156.
Great addition! The documentation now covers both major PostgreSQL drivers for Go:
- pgx: A more modern, feature-rich driver with advanced features like connection pooling
- pq: The traditional, widely-adopted
database/sqldriver
The new pq section follows the same clear structure as the pgx section with:
- Basic usage example showing standard
database/sqlpatterns - Connection string examples for both local and CrateDB Cloud setups
- Proper error handling guidance (using
sslmode=disablefor local,sslmode=requirefor cloud)
This gives users flexibility to choose based on their needs - pgx for more advanced features or pq for traditional database/sql compatibility. The documentation is comprehensive and consistent! 👍
4d9dcc3 to
58488ca
Compare
About
What the title says.
Preview
https://cratedb-guide--406.org.readthedocs.build/connect/go/