build(deps): bump github.com/golangci/golangci-lint/v2 from 2.8.0 to 2.10.1 in /tools - #429
Conversation
dependabot
Bot
added
dependencies
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
997839c to
9a9a9ad
Compare
| xzCutName, _ := strings.CutSuffix(filepath.Base(file.Name()), ".xz") | ||
| outPath := filepath.Join(targetDir, xzCutName) | ||
| out, err := os.Create(outPath) | ||
| out, err := os.Create(outPath) // #nosec G703 -- file is created in a temporary directory |
There was a problem hiding this comment.
G703 is "Path traversal via taint analysis" https://github.com/securego/gosec/blob/master/RULES.md
As I understand it, if gosec warns about this, this means it thinks the user could provide a specially crafted filename which would get the code to create the file outside of the temporary directory.
Maybe this is a false positive regardless, but I don’t think the fact that this is a temporary directory explains why.
| } | ||
| default: | ||
| fmt.Fprintf(&builder, ",fd=%d", dev.Socket.Fd()) | ||
| fmt.Fprintf(&builder, ",fd=%d", dev.Socket.Fd()) // #nosec G705 -- CLI arg, not HTML |
There was a problem hiding this comment.
A cli arg is still user provided and could be abused?
|
A newer version of github.com/golangci/golangci-lint/v2 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps [github.com/golangci/golangci-lint/v2](https://github.com/golangci/golangci-lint) from 2.8.0 to 2.10.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/main/CHANGELOG.md) - [Commits](golangci/golangci-lint@v2.8.0...v2.10.1) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint/v2 dependency-version: 2.10.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
This fixes this linter error:
```
pkg/config/bootloader.go:122:2: QF1012: Use fmt.Fprintf(...) instead of WriteString(fmt.Sprintf(...)) (staticcheck)
builder.WriteString(fmt.Sprintf(",variable-store=%s", bootloader.EFIVariableStorePath))
^
```
This fixes
```
pkg/config/virtio.go:480:14: G705: XSS via taint analysis (gosec)
fmt.Fprintf(&builder, ",fd=%d", dev.Socket.Fd())
^
```
This not generating web output, but a command line argument, and it’s
only possible to get an integer value.
This fixes this linter error:
```
pkg/config/virtio.go:518:35: G115: integer overflow conversion int -> uintptr (gosec)
dev.Socket = os.NewFile(uintptr(fd), "vfkit virtio-net socket")
^
```
This fixes:
```
cmd/vfkit/main.go:422:12: G703: Path traversal via taint analysis (gosec)
os.Remove(isoFile.Name())
test/osprovider.go:81:23: G703: Path traversal via taint analysis (gosec)
out, err := os.Create(outPath)
^
```
The one in main.go is a false positive.
The one in osprovider.go is also most likely not an actual problem, but
we can be sure there are no problems by using `os.Root` for the file
handling.
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
The cloud-init test uses a fedora image. With the release of f44, f42 images have been deleted, which leads to CI failures. Might still be better to use https://gitlab.com/fedora/websites-apps/fedora-websites/cms/fedoraproject.org/-/blob/main/content/release.yml?ref_type=heads or some similar file to get the version/rc_version of the latest fedora release. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
9a9a9ad to
35102ca
Compare
|
I’ve split the commits to fix one issue per commit, and to have the error messages in the commit log. @vyasgun please take a look before I merge this. |
|
@cfergeau the changes look good to me. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Bumps github.com/golangci/golangci-lint/v2 from 2.8.0 to 2.10.1.
Release notes
Sourced from github.com/golangci/golangci-lint/v2's releases.
... (truncated)
Changelog
Sourced from github.com/golangci/golangci-lint/v2's changelog.
Commits
5d1e709chore: prepare released5f2de2dev: refactor to use waitgroup.Go (#6377)31356b6fix: make markDepsForAnalyzingSource recursive to fix buildssa panic (#6376)cb54f49docs: update GitHub Action assets (#6374)c70f78edocs: update documentation assets (#6373)95dcb68chore: prepare release87a60c9build(deps): bump github.com/godoc-lint/godoc-lint from 0.11.1 to 0.11.2 (#6372)d9d4b19build(deps): bump honnef.co/go/tools from 0.6.1 to 0.7.0 (#6367)ab19213chore: improve the support of large numbers of packages (FilenameUnadjuster) ...abdeb8dbuild(deps): bump github.com/securego/gosec/v2 from 2.22.11 to 2.23.0 (#6366)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)