-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App: improve title translation, add caching, enable debug toolbar #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update title formula per previous pull request: #465 - improve accuracy of title translation - use legal code translation domains, when possible - add caching so additional overhead only causes a few seconds of additional processing time on a full publish, instead of an additional 6 minutes - clean-up manage.py
7 tasks
possumbilities
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, impressive!
Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
App: improve title translation, add caching, enable debug toolbar
manage.py
dev/coverage.sh
dev/stats.sh
Also see Data pull request:
Technical details
CC0 1.0 Universal
zero_10
)CC0 1.0 Universal
django
)CC0 1.0 Universell
Tests
command:
output excerpt:
Screenshots
The following screenshots show the Django Debug Toolbar cache details panel for
http://127.0.0.1:8005/licenses/by/3.0/deed.en
(Deed - Attribution 3.0 Unported - Creative Commons):First render with cache misses
Subsequent render with cache hits
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin