-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix no response / null response from LLM #3591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vidit-Ostwal
wants to merge
22
commits into
crewAIInc:main
Choose a base branch
from
Vidit-Ostwal:Invalid_response_from_LLM
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix no response / null response from LLM #3591
Vidit-Ostwal
wants to merge
22
commits into
crewAIInc:main
from
Vidit-Ostwal:Invalid_response_from_LLM
+183
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @lucasgomide, do you think this could be possible solution for this? I got some feedback from folks who tried the feature branch |
|
Gentle ping on this one @lucasgomide |
|
Added to my list to review later today |
3807072 to
5c9ac8f
Compare
|
mind you checking the CI errors? |
All fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a try solution for None / Empty response from LLM.
This PR assumes that this might be because of context length exceeded at the server side, which is not returning an error, just an empty response.
This PR captures the ValueError which is being raised and try again with summarization.
Note
Detect None/empty LLM responses as context-window overflows, trigger summarization/retry in executors, add utility and tests, and refine type hints.
ValueErrorwith empty/None LLM responses as potential context overflow via newis_null_response_because_context_length_exceeded.crewai/agents/crew_agent_executor.py,crewai/lite_agent.py) to handle this case alongsideis_context_length_exceeded, invokinghandle_context_lengthto summarize and retry.agent_utils.is_context_length_exceededsignature/docs; keep core detection; addLLMMessagetyping usage.is_null_response_because_context_length_exceeded(exception, messages, llm)inagent_utils.pyto infer overflow by chunking messages againstllm.get_context_window_size().BaseAgentinTaskEvaluatorand broaden tool execution types to acceptAgent | BaseAgent.tests/agents/test_agent.py,tests/utilities/test_agent_utils.py).Written by Cursor Bugbot for commit 62d1a85. This will update automatically on new commits. Configure here.