Conversation
thomas-nguy
requested review from
JayT106,
XinyuCRO,
crypto-matto and
devashishdxt
XinyuCRO
force-pushed
the
thomas/add-mint-to-weth9
branch
from
ecf71ee to
d669c8d
Compare
|
|
||
| function deposit() public payable { | ||
| balanceOf[msg.sender] += msg.value; | ||
| // Do not uses |
There was a problem hiding this comment.
do you mean don't use deposit and withdraw functions? or don't emit the events?
There was a problem hiding this comment.
we are keeping those methods to keep retro compability with the interface but since the l2 gas token is not wrapped ethereum, we dont need to use deposit or withdraw anymore
There was a problem hiding this comment.
we may be able to remove completely those functions actually
| return true; | ||
| } | ||
|
|
||
| function mint(address dest, uint wad) external { |
| // We allow executing such blocks. | ||
|
|
||
| require(block.timestamp > commitBlockTimestamp + executionDelay, "5c"); // The delay is not passed | ||
| require(block.timestamp >= commitBlockTimestamp + executionDelay, "5c"); // The delay is not passed |
There was a problem hiding this comment.
this is a small fix to avoid a bug on devnet when executionDelay is set to 0 and the sequencer try to commit and execute block within on tx (it should succeed)
| uint256 _l2TxGasPerPubdataByte, | ||
| address _refundRecipient | ||
| address _refundRecipient, | ||
| uint256 _gasAmount |
There was a problem hiding this comment.
Usually use the ERC20 bridge do not require l1Amount, we just use the _gasAmount as the l1Amount of requestL2
There was a problem hiding this comment.
okay can you update the comment then?
Co-authored-by: Xinyu Zhao <xinyu.zhao@crypto.com>
Co-authored-by: Xinyu Zhao <xinyu.zhao@crypto.com>
Co-authored-by: Xinyu Zhao <xinyu.zhao@crypto.com>
3 participants
l1WethBridge.depositto bridge custom WETH token as gas token in L2test script: #4