Update the webkit commit #34
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
requested changes
Feb 22, 2024
.github/workflows/ci.yml
Outdated
| - run: mkdir build | ||
| - run: Expand-Archive -Force WebKitRequirementsWin64.zip build/WebKitLibraries | ||
| - run: ls build/WebKitLibraries | ||
| - run: mkdir build2 |
There was a problem hiding this comment.
Can we use a better name than build2? Something that better explains how this is different from just build?
There was a problem hiding this comment.
This is addressed by 82866d3
Will rebase and use this PR to update the webkit commit and vendor pull.
There was a problem hiding this comment.
Keep in mind that we shouldn't merge this at all. These GitHub Actions changes are just for experimenting with WebKit builds. We should then integrate everything purely into CMake
bavulapati
force-pushed
the
debug-webkit
branch
from
888c312 to
c679e97
Compare
bavulapati
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webkit made a change that would help JSCOnly port on windows recently.
Ref: WebKit/WebKit#22908 (comment)