Update to function-sdk-go 0.5.0 #498
Draft
+278
−246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobh66
force-pushed
the
update_v2
branch
5 times, most recently
from
48602bc to
8c2e1a4
Compare
Signed-off-by: Bob Haddleton <[email protected]>
tenitski
reviewed
Oct 21, 2025
|
|
||
| // Initialize the requirements. | ||
| requirements := &fnv1.Requirements{ExtraResources: make(map[string]*fnv1.ResourceSelector)} | ||
| requirements := &fnv1.Requirements{Resources: make(map[string]*fnv1.ResourceSelector)} |
There was a problem hiding this comment.
Switching from ExtraResources to Resources will break things
See crossplane/function-sdk-go#219
There was a problem hiding this comment.
Yep, that's why I put it back in Draft. We need to maintain the existing API to the user, which means adding the "extraResources" key into the template context with the same content as "requiredResources". Not ideal, but here we are.
There was a problem hiding this comment.
Good catch @tenitski, thanks for the reminder here! 😥
Signed-off-by: Bob Haddleton <[email protected]>
Signed-off-by: Bob Haddleton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Update to function-sdk-go 0.5.0 which includes crossplane-runtime v2
I have: