Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ManagedIdentity and OIDC authentication methods #139

Merged

Conversation

gravufo
Copy link
Contributor

@gravufo gravufo commented Jun 28, 2024

Description of your changes

Implements Managed Identity and OIDC (workload identity) authentication methods based on the code in the Azure provider.
Fixes #17

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Manually tested the OIDCTokenFile method on our own cluster with our Azure subscription. Did not test the managed identity one, but it should work the same as on the Azure provider since both terraform providers handle authentication the same way.

@gravufo gravufo force-pushed the implement-more-auth-methods branch from 8bc4793 to a90ad2e Compare June 28, 2024 19:20
Signed-off-by: Christian Artin <[email protected]>
@gravufo gravufo force-pushed the implement-more-auth-methods branch from 997b54a to c390f06 Compare June 28, 2024 22:23
@gravufo
Copy link
Contributor Author

gravufo commented Jun 28, 2024

Possibly fixes #15 as well?

@marian-kapisinsky
Copy link

hi, please, what is the progress here? any ETA?

@gravufo
Copy link
Contributor Author

gravufo commented Jul 26, 2024

@turkenf any chance of getting this merged soon?

@Mikel-Landa
Copy link

@gravufo is there a reason you've included subscriptionId parameter? I believe it's not needed for AzureAd.

@gravufo
Copy link
Contributor Author

gravufo commented Jul 31, 2024

@Mikel-Landa you're absolutely right. I didn't realize that, thanks for the comment. I will push a version without the subscriptionId parameter.

@gravufo gravufo force-pushed the implement-more-auth-methods branch from f7d718b to 9ee24d7 Compare July 31, 2024 23:12
@turkenf
Copy link
Collaborator

turkenf commented Sep 4, 2024

/test-examples="examples/conditionalaccess/v1beta2/accesspolicy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Sep 4, 2024

/test-examples="examples/applications/v1beta1/application.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Sep 4, 2024

Close and re-open to trigger pipelines.

@turkenf turkenf closed this Sep 4, 2024
@turkenf turkenf reopened this Sep 4, 2024
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your effort @gravufo, I left a comment for you to consider.

Signed-off-by: Christian Artin <[email protected]>
@turkenf
Copy link
Collaborator

turkenf commented Sep 6, 2024

/test-examples="examples/applications/v1beta1/application.yaml"

https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/10734580094

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution @gravufo, and thank you for reviews @stonkie, @yunfhu 🙌

@turkenf turkenf merged commit 19c4cbd into crossplane-contrib:main Sep 6, 2024
10 checks passed
@gravufo gravufo deleted the implement-more-auth-methods branch September 6, 2024 14:11
@chatelain-io
Copy link

When do you plan to release this feature, this is a must-have when you don't want to managed service principals credentials.

Thank you

@turkenf
Copy link
Collaborator

turkenf commented Sep 18, 2024

When do you plan to release this feature, this is a must-have when you don't want to managed service principals credentials.

@chatelain-io, the planned release date is Thursday, September 26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the authenticating method using Managed Identity
7 participants