-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ManagedIdentity and OIDC authentication methods #139
Add support for ManagedIdentity and OIDC authentication methods #139
Conversation
Signed-off-by: Christian Artin <[email protected]>
8bc4793
to
a90ad2e
Compare
Signed-off-by: Christian Artin <[email protected]>
997b54a
to
c390f06
Compare
Possibly fixes #15 as well? |
hi, please, what is the progress here? any ETA? |
@turkenf any chance of getting this merged soon? |
@gravufo is there a reason you've included subscriptionId parameter? I believe it's not needed for AzureAd. |
@Mikel-Landa you're absolutely right. I didn't realize that, thanks for the comment. I will push a version without the |
Signed-off-by: Christian Artin <[email protected]>
f7d718b
to
9ee24d7
Compare
/test-examples="examples/conditionalaccess/v1beta2/accesspolicy.yaml" |
/test-examples="examples/applications/v1beta1/application.yaml" |
Close and re-open to trigger pipelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your effort @gravufo, I left a comment for you to consider.
Signed-off-by: Christian Artin <[email protected]>
/test-examples="examples/applications/v1beta1/application.yaml" https://github.com/crossplane-contrib/provider-upjet-azuread/actions/runs/10734580094 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do you plan to release this feature, this is a must-have when you don't want to managed service principals credentials. Thank you |
@chatelain-io, the planned release date is Thursday, September 26 |
Description of your changes
Implements Managed Identity and OIDC (workload identity) authentication methods based on the code in the Azure provider.
Fixes #17
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Manually tested the OIDCTokenFile method on our own cluster with our Azure subscription. Did not test the managed identity one, but it should work the same as on the Azure provider since both terraform providers handle authentication the same way.