Update WinSDK.js to handle recursively translation files - #151
Update WinSDK.js to handle recursively translation files#151fernandolguevara wants to merge 1 commit into
Conversation
|
@darktears, @pozdnyakov, @baleboy: ping @fernandolguevara: thanks for the patch. Can you be more descriptive in both the PR message and the commit message? Specifically, it would be good to explain what the problem was and what your patch does to fix it. Last but not least, it looks like you're using a different indentation than the rest of the code, so that needs to be fixed. |
|
@rakuco the problem is in the generation of wix file, the folder containing the translations also has sub folders with more translations files and the current code cant handle this, my patch fix that situation. I found another issue , if you run the generation of msi file some times the new msi file contains the olders ... |
|
I see. My point with updating your messages is that this sort of information should be part of the PR and, most importantly, the commit, so that people using |
34c38aa to
d9e6256
Compare
d9e6256 to
c782edd
Compare
|
@rakuco done |
fix issue - https://crosswalk-project.org/jira/projects/XWALK/issues/XWALK-7420?filter=allopenissues