deps: allow hf-hub to be optional#40
Merged
Merged
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
added a commit
to vllm-project/vllm
that referenced
this pull request
Jun 23, 2026
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
AlonKejzman
approved these changes
Jun 23, 2026
BugenZhao
added a commit
to vllm-project/vllm
that referenced
this pull request
Jun 25, 2026
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When used directly as a Rust library, the caller may want to handle downloading the model files themselves, especially if it's under an async context.
This PR makes
hf-huban optional dependency so users can opt-out transitive dependency onhf-hub, thenureqorrustls. When it's disabled, interfaces includingfrom_model,from_model_with_token, anddownload_tokenizer_jsonwon't be available.The feature is kept enabled by default, so there won’t be any breaking changes on the user-facing side.