Skip to content

The Unstaged Update #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,9 @@ API_BASE_URL=http://localhost:4000
# The URL that @cryb/web is being hosted on. Locally, this would be 'http://localhost:3000'
WEB_BASE_URL=http://localhost:3000

######################################
# JSMPEG #
######################################
# (Note: Rates are in kb/s and should match with portal's)
#VIDEO_BITRATE=1200
#AUDIO_BITRATE=128

######################################
# Janus #
######################################
# ENABLE_JANUS controls which JS libraries the end user receives.
ENABLE_JANUS=true

# Controls the URL @cryb/web will go try to connect to for WebRTC negotiation
# ToDo: Move this to be negotiated with API/portals.
JANUS_URL=http://localhost:8088
Expand All @@ -51,15 +41,12 @@ TURN_PASSWORD=
# The domain used while setting cookies. Locally, this would be 'localhost'. In production, this would be '.example.com'
COOKIE_DOMAIN=localhost
# Nuxt.js Defaults
NUXT_HOST=0.0.0.0
NUXT_PORT=3000
HOST=0.0.0.0
PORT=3000
# Optional: Show player's devtools - useful for debugging
# SHOW_PLAYER_DEVTOOLS=true
# Optional: link to local Borealis repository for @cryb/borealis development.
# BOREALIS_REPOSITORY=

# Dist files public path - useful if you want to use a CDN
# PUBLIC_PATH=/_cryb/

# Rendering mode - This should be set to 'ssr' for SSR, otherwise it'll use 'spa'.
# RENDER_MODE=spa
2 changes: 0 additions & 2 deletions .eslintignore

This file was deleted.

1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ typings/

# nuxt.js build output
.nuxt
.output
dist

# vuepress build output
Expand Down
7 changes: 2 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,7 @@ git clone https://github.com/crybapp/web.git
The following services need to be installed for `@cryb/web` to function:

* `@cryb/api`

We recommend that you run the following services alongside `@cryb/web`, but it's not required.

* `@cryb/aperture` or Janus WebRTC Server
* Janus WebRTC Server (used for VM streams)

You also need to install the required dependencies by running `yarn`.

Expand All @@ -75,7 +72,7 @@ In this file, you'll need some values. Documentation is available in the `.env.e

Make sure that you have installed `@cryb/api`.

If you're developing a feature that requires the VM infrastructure, then make sure either `@cryb/aperture` or Janus WebRTC server is running.
If you're developing a feature that requires the VM infrastructure, then make sure Janus WebRTC server is running.

#### Starting @cryb/web

Expand Down
114 changes: 0 additions & 114 deletions app/components/nuxt-build-indicator.vue

This file was deleted.

8 changes: 7 additions & 1 deletion components/Chat/GroupedChatMessage.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
<template>
<div v-if=author class="grouped-chat-messages" @mouseover="hover = true" @mouseleave="hover = false">
<img v-if=userIcon :src=userIcon class="chat-messages-author-avatar" :class="{ 'has-control': hasControl, 'owner': isOwnerOfRoom }">
<img
v-if=userIcon
class="chat-messages-author-avatar"
:class="{ 'has-control': hasControl, 'owner': isOwnerOfRoom }"
decoding="async"
:src=userIcon
>
<div class="chat-messages">
<div class="grouped-chat-messages-meta">
<p class="chat-messages-author-name">
Expand Down
2 changes: 1 addition & 1 deletion components/Chat/InputBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<script>
import { mapGetters } from 'vuex'

import emoji from 'node-emoji'
import * as emoji from 'node-emoji'
import { stripHtml } from 'string-strip-html'

export default {
Expand Down
2 changes: 1 addition & 1 deletion components/Chat/Message.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<script>
import { mapGetters } from 'vuex'
import { stripHtml } from 'string-strip-html'
import twemoji from 'twemoji'
import twemoji from '@twemoji/api'

export default {
props: [
Expand Down
2 changes: 1 addition & 1 deletion components/Header/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<RoomMenu ref="roomMenu" />
</div>
<div v-if=user class="right">
<img v-if=userIcon :src=userIcon class="profile-image" @click=toggleUserMenu()>
<img v-if=userIcon decoding="async" class="profile-image" :src=userIcon @click=toggleUserMenu()>
<UserMenu ref="userMenu" />
</div>
<div v-else-if=token class="right">
Expand Down
7 changes: 2 additions & 5 deletions components/Player/Footer.vue
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,9 @@
}
},
computed: {
...mapGetters(['apertureWs', 'apertureToken', 'controllerId', 'controlLocked', 'fullscreen', 'janusId',
'pip', 'portalStatus', 'room', 'users', 'userId', 'onlineUsers', 'viewerMuted']),
...mapGetters(['controllerId', 'controlLocked', 'fullscreen', 'janusId', 'pip', 'portalStatus',
'room', 'users', 'userId', 'onlineUsers', 'viewerMuted']),

isJanusEnabled() {
return process.env.ENABLE_JANUS
},
hasControl() {
return this.controllerId === this.userId
},
Expand Down
4 changes: 2 additions & 2 deletions components/Player/UserIcon.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<div v-if=member class="user-icon" :class="{ 'passable': canPassControl, 'offline': !isUserOnline, 'has-control': hasControl, 'owner': isOwnerOfRoom }" @click=didClickUserIcon() @mouseover="hover = true" @mouseleave="hover = false">
<img v-if=userIcon :src=userIcon class="user-icon-avatar" :title="userHoverTitle" />
<img v-if=userIcon class="user-icon-avatar" :title="userHoverTitle" decoding="async" :src=userIcon />
<div class="user-name-wrapper">
<p class="user-name">
{{ member.name }}
Expand Down Expand Up @@ -47,7 +47,7 @@
if (this.canPassControl) return `Give the controller to ${this.member.name}`
if (this.hasControl) return `${this.member.name} has the controller`

return `${this.member.name}${this.isUserSelf ? ' (you)' : ''}`
return 'How are you here?'
},

interactable() {
Expand Down
Loading