Skip to content

Conversation

@XinyuCRO
Copy link

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@github-actions github-actions bot added the evm label Dec 18, 2025
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.99%. Comparing base (1f5d360) to head (9972929).

Files with missing lines Patch % Lines
x/evm/keeper/grpc_query.go 44.44% 7 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.22.x     #810      +/-   ##
===================================================
- Coverage            47.00%   46.99%   -0.02%     
===================================================
  Files                  187      187              
  Lines                15224    15228       +4     
===================================================
  Hits                  7156     7156              
- Misses                7278     7280       +2     
- Partials               790      792       +2     
Files with missing lines Coverage Δ
x/evm/keeper/state_transition.go 76.03% <100.00%> (+0.09%) ⬆️
x/evm/keeper/grpc_query.go 73.95% <44.44%> (-0.72%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@XinyuCRO XinyuCRO marked this pull request as ready for review December 18, 2025 07:00
@XinyuCRO XinyuCRO requested a review from a team as a code owner December 18, 2025 07:00
@XinyuCRO XinyuCRO requested review from songgaoye and thomas-nguy and removed request for a team December 18, 2025 07:00
Copy link

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall 👌

// limit for these cases anyway.
// Use ExecutionGasUsed (actual gas before minGasMultiplier adjustment) for accurate estimation.
if result.ExecutionGasUsed > 0 {
lo = result.ExecutionGasUsed - 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it -1?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the binary search will start with lo+1


# Compare results from ethermint and geth
for result in (ethermint_result, geth_result):
assert result["gas_diff"] == 0, (

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert gas_diff equals to 0 only works for a tx that doesn't trigger gas refunds.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, in this call there is no refund

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants