-
Notifications
You must be signed in to change notification settings - Fork 0
Remove iframe teleport #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
therealJonSnow
wants to merge
199
commits into
main
Choose a base branch
from
bug/remove-iframe-teleport
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
therealJonSnow
commented
Jun 18, 2024
- Iframe teleport caused error when navigating away from city page.
- Seems like teleport can be buggy when using SSR, so removed and used simpler solution and an increased z-index to overcome overlapping navigation.
These all need to be merged
Experimental fix for gql requests
i18n introduced along with new routing methodoloy. Also includes some performance improving changes
…uilding for netlify_edge
Iframe teleport caused error when navigating away from city page. Seems like teleport can be buggy when using SSR, so removed and used simpler solution.
Iframe teleport caused error when navigating away from city page. Seems like teleport can be buggy when using SSR, so removed and used simpler solution.
✅ Deploy Preview for kryptostadt-info ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
52226b0
to
6f6e99b
Compare
…ocity-network/cryptocity into bug/remove-iframe-teleport
fd70a13
to
d53d222
Compare
063fa00
to
82f04d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.