Skip to content

Conversation

@franziskuskiefer
Copy link
Member

@franziskuskiefer franziskuskiefer commented Dec 16, 2025

Bump versions and silence some more warnings.

We could make the warning stronger that this breaks things. Let me know what you think.

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.57%. Comparing base (254ad3a) to head (ef55873).

Files with missing lines Patch % Lines
src/lib.rs 60.00% 2 Missing ⚠️
src/kem.rs 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   32.71%   32.57%   -0.15%     
==========================================
  Files          16       16              
  Lines        6357     6360       +3     
==========================================
- Hits         2080     2072       -8     
- Misses       4277     4288      +11     
Files with missing lines Coverage Δ
traits/src/types.rs 53.36% <ø> (+0.73%) ⬆️
src/kem.rs 31.46% <0.00%> (ø)
src/lib.rs 21.75% <60.00%> (-0.30%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jschneider-bensch jschneider-bensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think, just some nits and a suggestion for making the breaking change more apparent on hpke-rs.

@franziskuskiefer franziskuskiefer enabled auto-merge (squash) December 17, 2025 06:39
@franziskuskiefer franziskuskiefer merged commit abe04aa into main Dec 17, 2025
17 checks passed
@franziskuskiefer franziskuskiefer deleted the franziskus/release-0.5 branch December 17, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants