Add fiber safety to object class getter/property macros #15387
+2,753
−1,060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
commented
Jan 28, 2025
ysbaddaden
force-pushed
the
feature/add-fiber-safety-to-object-property-macros
branch
from
c77343c to
a888edb
Compare
|
Damn. The interpreter is still broken on windows. |
|
I'm using the released 1.15.0 compiler for windows. I'm running The interpreter on windows can't reach |
|
Yeah, if I call |
|
Gotcha 🐛 The interpreter requires the prelude which in turn:
I guess we should load |
The interpreter on windows segfaults because `Crystal::Once.init` wasn't
called soon enough:
- require "string"
- require "string/builder"
- require "io"
- require "io/file_descriptor"
- require "crystal/system/win32/file_descriptor"
- at_exit <== inlined call!
- Crystal::AtExitHandlers#class_getter(handlers) { ... } <== calls Crystal.once!
- (...)
- require "crystal/main"
- Crystal.init_runtime
- Crystal::Once.init <== only initialized now!
Requiring crystal/main sooner makes sure that the interpreter will
execute `Crystal.init_runtime` before any other inlined call that may
depend on `Crystal.once`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14905
Builds on top of the prerequisite refactors/features. Only the last commit actually implements the feature.