-
-
Notifications
You must be signed in to change notification settings - Fork 24
Snap: core22 + arm64 build target + make push #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Back to DRAFT. It's not working, the docker image is var outdated (3 years ago) and We shall upgrade to https://github.com/canonical/snapcraft-rocks and core22 or core24 (recommended). I'm testing locally, but I'm hitting issues with |
|
Wonderful the official docker images |
b8a3b98 to
b535b07
Compare
|
After fighting for too many houurs, I found out that we don't need the snapcraft-rocks docker image, LXD or even multipass: we can just install snapd, snapcraft then build as the current user on the host itself with |
|
I'll try to upgrade to |
|
I'm trying to get snapd & snapcraft setup on CircleCI, and I don't succeed so far. |
|
It finally built 😅 Publish is broken (needs a |
straight-shoota
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OP is out of date: It should use ARCH, maybe other changes need to be mentioned as well, there or in the readme?
| adopt-info: crystal | ||
|
|
||
| architectures: | ||
| - build-on: [amd64] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Is it not possible to build on arm64 for amd64?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we can.
e837952 to
c6ca8ec
Compare
|
I added the CircleCI will |
|
I updated the PR description with all the latest changes. |
Upgrades to
core22(Ubuntu 22.04) fromcore(16) that didn't support architectures in addition to be very outdated.Declares the
arm64target in addition to theamd64target. Both can be built on either target, but because of the target specific tarball, they must each be built separately.Adds the
make pushtarget as a convenient helper.The
Makefilenow takes explicit variables instead of implicit environment variables:ARCH: any architecture supported by crystal & snap (amd64andarm64).GRADE: the snap grade (develorstable).CHANNEL: the snap channel (edgeoredge/<branch>).For example: