feat: Improve STDIO transport layer for large JSON-RPC inputs #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
cs3b
commented
Apr 5, 2025
cs3b
commented
- Non-blocking reads with read_nonblock: Avoids stalling the thread when no input is available.
- Custom buffering: Handles partial reads, which can happen when a long message is sent in chunks.
- Safer handling of large inputs: Introduces @max_line_size = 1MB to prevent memory abuse (e.g., if a client sends a huge unbroken stream).
- Error logging and cleanup on oversized or malformed input.
This commit introduces four new example prompts demonstrating different use cases for code review, including inline prompt, multi-message prompt with context, and two separate ERB templates. It also includes a `prompt_code_review.rb` file that utilizes ERB templates to construct the assistant and user messages for a code review scenario.
and update changelog with prompt features
* Non-blocking reads with read_nonblock: Avoids stalling the thread when no input is available. * Custom buffering: Handles partial reads, which can happen when a long message is sent in chunks. * Safer handling of large inputs: Introduces @max_line_size = 1MB to prevent memory abuse (e.g., if a client sends a huge unbroken stream). * Error logging and cleanup on oversized or malformed input.
cs3b
added a commit
that referenced
this pull request
Apr 13, 2025
- Reverted version in lib/mcp/version.rb from 1.1.1 to 1.0.0 - Updated Gemfile.lock to reflect version change - Modified CHANGELOG.md to move 1.1.0 and 1.1.1 features to Unreleased section - Removed gem files for versions 1.1.0 and 1.1.1 Closes task #1-version-revert-to-original
cs3b
force-pushed
the
server-prompts-feature
branch
3 times, most recently
from
46d5948 to
f1835b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.