Merge pull request #5071 from bastianbeier/fix/role-conversion

Fix role conversion
cs3org · Feb 5, 2025 · 2a7145a · 2a7145a
2 parents f046425 + 1b81709
commit 2a7145a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/changelog/unreleased/fix-role-conversion.md b/changelog/unreleased/fix-role-conversion.md
@@ -0,0 +1,5 @@
+Bugfix: Role conversion
+
+Fix role from resource permission conversion
+
+https://github.com/cs3org/reva/pull/5071
diff --git a/pkg/conversions/role.go b/pkg/conversions/role.go
@@ -617,7 +617,7 @@ func RoleFromResourcePermissions(rp *provider.ResourcePermissions, islink bool)
 			if rp.ListGrants {
 				r.Name = RoleEditorListGrants
 			}
-			if rp.RemoveGrant && rp.ListFileVersions {
+			if rp.ListGrants && rp.ListFileVersions {
 				r.Name = RoleEditorListGrantsWithVersions
 			}
 			if rp.RemoveGrant {