ocm share notification handling added #5075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
2403905
force-pushed
the
issue-7075
branch
2 times, most recently
from
0463dae to
9387a6b
Compare
9 tasks
2403905
requested review from
kobergj
and removed request for
a team,
labkode and
glpatcern
kobergj
requested changes
Feb 14, 2025
| } | ||
| case payload.SHARE_CHANGE_PERMISSION: | ||
| // TODO implement the SHARE_CHANGE_PERMISSION | ||
| w.WriteHeader(http.StatusNotImplemented) |
There was a problem hiding this comment.
Will we implement this too? That has impact on https://github.com/owncloud/web/issues/12149
There was a problem hiding this comment.
Yes, I think we can try to implement the permission update properly. I not, we can fall back to thedelete-create scenario.
| @@ -589,6 +595,23 @@ func (m *mgr) GetReceivedShare(ctx context.Context, user *userpb.User, ref *ocm. | |||
| return nil, errtypes.NotFound(ref.String()) | |||
| } | |||
|
|
|||
| func (m *mgr) DeleteReceivedShare(ctx context.Context, user *userpb.User, ref *ocm.ShareReference) error { | |||
There was a problem hiding this comment.
exported type DeleteReceivedShare should have a comment or be unexported
There was a problem hiding this comment.
skipped. All exported methods are in a json.go implements the interfaces that have a comment
kobergj
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ocm notification handler that allows receiving a notification from a remote party about changes to a previously known entity.