Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "TypeError: BufferedWriter.write() takes no keyword arguments" error in localiface.py #152

Merged
merged 1 commit into from
May 24, 2024

Conversation

daniel-pro
Copy link
Contributor

Description

This PR is a fix for the following error:

File "/app/core/localiface.py", line 286, in writefile written += f.write(chunk, offset=o, size=len(chunk))
TypeError: BufferedWriter.write() takes no keyword arguments

that occurs when a file must be saved and the local storage type is used.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fix for the error:
File "/app/core/localiface.py", line 286, in writefile written += f.write(chunk, offset=o, size=len(chunk))
TypeError: BufferedWriter.write() takes no keyword arguments
@daniel-pro daniel-pro requested a review from glpatcern as a code owner May 24, 2024 13:00
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. May I ask you how are you running the wopiserver in your system?

Just to note that the local interface has never run in production environment and it's there for demo/test purposes.

@glpatcern glpatcern merged commit 1b2c5fd into cs3org:master May 24, 2024
4 checks passed
@daniel-pro
Copy link
Contributor Author

daniel-pro commented May 24, 2024

I'm running it as a docker container on a Linux system, built using the wopiserver.Dockerfile.

Yes, I'm aware of the fact that the local interface it's there for test purposes.

@glpatcern
Copy link
Member

Thanks, that's fine, and can you tell more about your use case? You may also message me privately if you prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants