Matched values in FakeResponse.text to return from json #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text in the FakeResonse was not matching the json returned by the mocked json method. Live response from the API shows that these values match. A student with some Python experience was using the json library to convert the text into the data for their solution. Check50 showed the slightly differing results vs the expected data from the FakeResponse. This gave little direction to fix the issue, beyond "follow the hints", which solved the issue.
I changed the values in the text section to match the response. To be thorough, I copied both to files and used python to compare. I ran a check50 test on a new version of bitcoin.py that uses the json library to verify.