-
Notifications
You must be signed in to change notification settings - Fork 21
Update for latest version of gimli.units #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A lot of files were updated, but most of the changes were updates from black and flake8 to get get the tests passing. I also modified the CI workflows to get them to the point of running the unit tests. |
@mcflugen Would you mind taking a look at this, please? The last few tests that are failing are from changes in gimli.units, and I'm not sure how best to proceed.
If you could fix these, or let me know how to fix them, I'd appreciate it. |
The subsequent call to `mamba install` updates *shapely* to 2.0, which breaks the <1.9 requirement from #164.
806ea54
to
556183d
Compare
@mdpiper I've fixed the failing gimli.units tests. Most of those tests were simply testing gimli, not pymt, and are, in fact, repeated almost verbatim in the unit tests of the gimli package. As such, I just removed them as they are redundant and don't belong in pymt. NOTE: I've rebased this branch with master so you'll have to update your local branch before making any additional changes. |
The notebook tests are failing because pymt_gipl and pymt_ecsimplesnow aren't built on osx_arm64 (#172). I've updated the ecsimplesnow feedstock and I'm waiting on pymt_ecsimplesnow. gipl isn't compiling, but I think I can fix it. I'll then go through the process of updating its feedstocks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The latest version of gimli.units (v0.3.2) includes some significant changes that are breaking pymt. This PR is an attempt to update pymt to work with gimli.units. I'm trying to make as few changes as possible to 1) get the tests passing again and 2) ensure that gimli.units is being used correctly in pymt.
This fixes #168.