First Release #107
Open
First Release #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Xcode project using SwiftUI
Currently, the `GridView` only works with Strings. However, with some work we can make it generic. SF Symbols were used as placeholders for the buttons. There are several small UI bugs which I couldn't solve. I will add them to the Issues later.
Add the UI as the prototype
…nstormingViewModel and IntroViewModel
Add the Multipeer singleton and the basic multipeer logic in the Brai…
Feature/multipeer connection ios
Feature/multipeer connection
Unit Test of votes counting method was added too.
This is a quick-fix commit that fixes a function that converts a array of String Type to a 2D Matrix of String Type. This Matrix will have 3 columns
Combine UI with The Brainstorm VM
Create tvos ideas list broadcast methods
The tests told us that the function that converts the String type array to a 2D String type matrix was not working due to going out of index. Now the function is fixed and the tests are validated.
Correctly labeled and organized the data flow between Views and ViewModels. Also cleaned up a bit `GridView` and created a new grid struct when voting is enabled, called `GridViewVotable`.
Tests/unit tests
I've added some TODO to remind us to solve some issues. There are some seemingly unnecessary functions in the ViewModels. Also the test for the counting of the votes may not be necessary as I think the function should be private.
Structural change/brainstorming screen
This is just a quick-fix that solves the problems stated on the title.
Fix brainstorm timer not being invalidated and RankingView problems
Update app version (1.1) and fix some interface bugs
Motivation: The user, both in the iOS and tvOS, could only vote in one idea. This could make the usage of the app not optimal and sometimes frustrating. Modification: Removed both in the GridViewVotable and VotingView in iOS the map function that toggled off the selected idea that would be voted on when another idea is selected. Results: Users can now vote in more than one idea.
Hotfix/ios layout
Make it able to vote in more than one idea
Add Blink Icon on tvOS Menu
Fix grid view missing word
Update the README with additional information.
Update README.md
Add full icon to README
Add logo to README.md
csfar
approved these changes
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.