remove namespace name from pvc owner annotation #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikhil-Ladha
force-pushed
the
remove-ns-pvc-annotation
branch
from
a92a367 to
261102a
Compare
Contributor
Author
|
Created PR #823 to fix the Mergify config |
Collaborator
|
@Mergifyio rebase |
nixpanic
force-pushed
the
remove-ns-pvc-annotation
branch
from
261102a to
dc3d0d6
Compare
✅ Branch has been successfully rebased |
Contributor
Author
|
The CI looks good now, can we please have the changes reviewed as well? |
nixpanic
approved these changes
Jun 25, 2025
Collaborator
nixpanic
left a comment
nixpanic
left a comment
There was a problem hiding this comment.
Looks good to me.
Is there a problem with the namespace prefix in the owner reference?
Contributor
Author
The change to have namespace in the annotation is not backward compatible. Upgrade won't work, as csi-addons would return a name mismatch for pvcs |
Rakshith-R
approved these changes
Jun 25, 2025
Member
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b78405b |
11 tasks
remove namespace name from pvc owner annotation. Name should be enough to identify vgr/vr the pvc belongs to as the annotation key for vr and vgr is different and both are namespaced scope CRs which would belong to the same namespace as PVC. Signed-off-by: Nikhil-Ladha <[email protected]>
mergify
bot
force-pushed
the
remove-ns-pvc-annotation
branch
from
dc3d0d6 to
6140332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove namespace name from pvc owner annotation.
Name should be enough to identify vgr/vr the pvc belongs to as the annotation key for vr and vgr is different and both are namespaced scope CRs which would belong to the same namespace as PVC.