Teach TemplateNonTypeArgToInt to replace template params, too. #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
force-pushed
the
TemplateNonTypeArgToInt
branch
from
615ff8e to
80f3525
Compare
Member
|
FWIW, I would suggest leaving the test out of this pull request, since (as noted) it doesn't make sense until something else is resolved. |
Contributor
Author
|
Thanks for the prompt response! I don't want to lose the regression. I am not in hurry, I can wait a while. |
Member
|
Hi Vassil, I made some small changes to your patch and committed it without the test. Let's keep the pull request open for holding the test case. Thanks for sending us the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attached test should work once #82 is resolved.