Skip to content

Fixed Minimal theme issues when appMode=game #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ct6502 merged 2 commits into from
Oct 29, 2025
Merged

Fixed Minimal theme issues when appMode=game #189

ct6502 merged 2 commits into from
Oct 29, 2025

Conversation

@boredsenseless
Copy link
Collaborator

@boredsenseless boredsenseless commented Oct 29, 2025

BEFORE:
image

AFTER:
image

@boredsenseless boredsenseless requested a review from ct6502 October 29, 2025 21:08
ct6502
ct6502 approved these changes Oct 29, 2025
View reviewed changes
Copy link
Owner

@ct6502 ct6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - seems like my one change to isGameMode in "isMinimalTheme" was the culprit, but I like how you refactored the rest of the code

@ct6502 ct6502 merged commit e1aad38 into main Oct 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ct6502 ct6502 ct6502 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@boredsenseless @ct6502