Skip to content

Improved perf when passing BASIC code via query string #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ct6502 merged 2 commits into from
Dec 17, 2025
Merged

Improved perf when passing BASIC code via query string #195

ct6502 merged 2 commits into from
Dec 17, 2025

Conversation

@boredsenseless
Copy link
Collaborator

@boredsenseless boredsenseless commented Dec 17, 2025

Screen Recording 2025-12-16 at 4 49 29 PM

Changes made:

  • Replaced hard-coded sleep with wait for prompt via exPectin in handleInputParams()
  • Updated handleInputParams() to temporarily set max emulator speed when pasting BASIC code
  • Added MaximumSpeedMode const to speeddropdown.tsx

Tests performed:

  • Verified previous emulator speed is restored after BASIC code is "typed"
  • Verififed on multiple devices (Mac, PC, iPhone, iPad) and browsers (Chrome, Edge, Safari, Firefox)

Issues resolved:

  • n/a

ct6502
ct6502 approved these changes Dec 17, 2025
View reviewed changes
Copy link
Owner

@ct6502 ct6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me - nice change!

@ct6502 ct6502 merged commit cecd25d into main Dec 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ct6502 ct6502 ct6502 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@boredsenseless @ct6502