Donations and Volunteers Tables Select Frequency #109 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander Yin <[email protected]>
IsaacNguyen
previously requested changes
Apr 1, 2025
There was a problem hiding this comment.
Fantabulous work guys! Everything looks great, but I listed a few issues down below. I know the Total Value cell on the left wasn't originally your job but we gotta fix it up!
The columns should be renamed for clarity ("value" to "price per pound" and "total" to "total value"). Also we need to fix the Total Value cell on the left accordingly to calculate the total of the total values not the prices per pound.
There should be default values on the left (like 0) if no rows are found.
There should be no checkboxes on the left when in monthly or yearly view as to prevent deletion. There should be the id numbers displayed however.
Co-authored-by: Alexander Yin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
only issue is that it's kinda slow when switching between frequencies
Screenshots/Media
Issues
Closes #109