-
Notifications
You must be signed in to change notification settings - Fork 0
Added sorting to all tables #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done with the task! Everything seems good, the only issue is that the order should be descending first and then ascending. When I click on the titles it starts with ascending then descending, super minor change. Other than that great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
had to turn all tables into a tanstack table in order to implement sorting uhh good luck with merge conflicts with last updated function
Screenshots/Media
client statistics table

forms table

donations table

manage accounts table

volunteers table

Issues
Closes #112
Additional Notes
for client page and forms page, should the default behavior for pressing export be an empty file? it currently only exports the selected rows so if no rows are selected then it shows an empty file. would it make more sense to have it export all the clients?
also tanstack is p neat and supports multisort so it could be worthwhile to mention to NPO that if they hold down shift and click on other columns, it'll do multisort