Skip to content

Added sorting to all tables #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 3, 2025
Merged

Conversation

maithyy
Copy link
Member

@maithyy maithyy commented Mar 31, 2025

Description

had to turn all tables into a tanstack table in order to implement sorting uhh good luck with merge conflicts with last updated function

Screenshots/Media

client statistics table
image

forms table
image

donations table
image

manage accounts table
image

volunteers table
image

Issues

Closes #112

Additional Notes

for client page and forms page, should the default behavior for pressing export be an empty file? it currently only exports the selected rows so if no rows are selected then it shows an empty file. would it make more sense to have it export all the clients?

also tanstack is p neat and supports multisort so it could be worthwhile to mention to NPO that if they hold down shift and click on other columns, it'll do multisort

@maithyy maithyy self-assigned this Mar 31, 2025
Copy link
Collaborator

@benson-fm benson-fm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done with the task! Everything seems good, the only issue is that the order should be descending first and then ascending. When I click on the titles it starts with ascending then descending, super minor change. Other than that great work!

srukelman
srukelman previously approved these changes Apr 3, 2025
Copy link
Collaborator

@srukelman srukelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srukelman srukelman merged commit 8f56c8a into main Apr 3, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Table Sorting To All Tables
4 participants