115 sessions select implement waive fees payment status changes #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… includes dates and waive fee base implementation
… Archive functionalities update the backend and refresh modal accordingly
…d logic, cleaned up invoices code
jessieh9
reviewed
Apr 21, 2025
jessieh9
reviewed
Apr 21, 2025
jessieh9
reviewed
Apr 21, 2025
jessieh9
reviewed
Apr 21, 2025
jessieh9
reviewed
Apr 21, 2025
jessieh9
reviewed
Apr 21, 2025
jessieh9
reviewed
Apr 21, 2025
jessieh9
requested changes
Apr 21, 2025
There was a problem hiding this comment.
Hi @kunaidyp @Xire7, just a couple of changes:
-
I made some single comments on the file themselves. Please check them out and make the necessary changes according to the comments. (Most of these are in regards to endpoints and some files)
-
For the select sessions, the Cancel button should show the number of sessions that are selected, i.e 2 selected sessions would show the button "Cancel 2"
- You can keep the functionality for Select All. This fix only applies to Single Select
-
For waiving fees, show all selected sessions to cancel in the waive fees modal using a scrollable component (3 sessions then scroll)
- If it is less than 2 weeks before the session date, give the option to waive fees in the checkbox and prioritize showing these first
- If it is more than 2 weeks in advance, automatically waive fees by showing the session with a checked, non-editable checkbox
Other than that, good work.
5 tasks
added 7 commits
April 21, 2025 10:26
…ions.module.css, SessionsToolbar.jsx
…to filtering from all comments in frontend
… sessions that were manually inputted didn't work because their eventID doesn't actually exist. otherwise, on valid bookings with valid eventId's archive works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots/Media
Issues
Closes #