Skip to content

Network error code fix #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Network error code fix #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09a4422
Improve the network error test for checking `code` property
Jul 13, 2023
94cf810
Add "ERR_NETWORK" code into point of creating network error
Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,14 @@ VERBS.concat("any").forEach(function (method) {

networkError: function () {
return reply(function (config) {
var error = utils.createAxiosError("Network Error", config);
var error = utils.createAxiosError("Network Error", config, undefined, "ERR_NETWORK");
return Promise.reject(error);
});
},

networkErrorOnce: function () {
return replyOnce(function (config) {
var error = utils.createAxiosError("Network Error", config);
var error = utils.createAxiosError("Network Error", config, undefined, "ERR_NETWORK");
return Promise.reject(error);
});
},
Expand Down
1 change: 1 addition & 0 deletions test/network_error.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ describe("networkError spec", function () {
function (error) {
expect(error.config).to.exist;
expect(error.response).to.not.exist;
expect(error.code).to.equal("ERR_NETWORK");
expect(error.message).to.equal("Network Error");
expect(error.isAxiosError).to.be.true;
}
Expand Down