Typeahead column header fix #346
Merged
+73
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
droberts-ctrlo
commented
Feb 20, 2024
droberts-ctrlo
commented
- Added bloodhound for debounce and query efficiency
- Upped limit on results (bug on typeahead means that setting this to the max you expect means that the system will be erratic with the returned results, and miss values off)
- Added scroll and max height to result display
- Added bloodhound for debounce and query efficiency - Upped limit on results (bug on typeahead means that setting this to the max you expect means that the system will be erratic with the returned results, and miss values off) - Added scroll and max height to result display
Filter wasn't forwarding query, meaning all results were being returned, not just those required by the typeahead - this has been fixed. Also added scrolling for filter going off end of page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.