Updates to reporting as advised #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
droberts-ctrlo
commented
Feb 26, 2024
droberts-ctrlo
commented
- Fixed display for curvals
- Added generation and last edited timestamps
- Open in new tab
- Secured URLs for invalid report instances
- Secured access to deleted reports
- Error added for incorrect file given for upload
- Logo now displays when present on load
- Created and Edited on added
- Added select all checkbox to fields
- Updated view to use simpler URL for historic reports.
Moved schema version to correct number (104)
Further changes probably required - see comments.
- `security_marking` was not included in the report view - Cleaned up return for `_build_security_marking` in layout.pm - Cleaned up return for `read_security_marking` in schema result instance.pm - Fixed typo in input component and cleaned up code slightly - Fixed settings page for reports within current site styling - Found security_marking and title were missing in reports edit.tt - these have been added - Modified view of reports view.tt to bring it closer to current site styling
Changes based on suggestions by AB - render code by topic has been heavily refactored to use existing code.
Turns out I fixed the menu issue previously - the menu will wrap the report names appropriately.
- Open in new tab - Secured URLs for invalid report instances - Secured access to deleted reports - Error added for incorrect file given for upload - Logo now displays when present on load - Created and Edited on added
|
Thanks Dave. Just one minor update - can you use |
|
Closing PR and opening new one on fresh branch as PR was merged manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.