Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of deleted date to person field [B: 1742] #484

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

droberts-ctrlo
Copy link
Contributor

No description provided.

@droberts-ctrlo droberts-ctrlo changed the title Addition of deleted date to person field Addition of deleted date to person field [B: 1472] Dec 2, 2024
@droberts-ctrlo droberts-ctrlo changed the title Addition of deleted date to person field [B: 1472] Addition of deleted date to person field [B: 1742] Dec 2, 2024
@abeverley
Copy link
Contributor

I think we discussed this - it should be possible to make some improvements by returning the DateTime object and then obtaining the epoch from that, rather than creating a new function.

@droberts-ctrlo
Copy link
Contributor Author

I think we discussed this - it should be possible to make some improvements by returning the DateTime object and then obtaining the epoch from that, rather than creating a new function.

We did - it's on my list. 😄

@abeverley abeverley merged commit 9422cb0 into ctrlo:dev Dec 18, 2024
5 of 6 checks passed
@droberts-ctrlo droberts-ctrlo deleted the person-deleted-lua branch December 18, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants