-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart updates [B:708] #510
Draft
droberts-ctrlo
wants to merge
45
commits into
ctrlo:dev
Choose a base branch
from
droberts-ctrlo:chart-updates
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded basic packages in `package.json` to latest version where possible - Updated `webpack.config.js` to use latest versions of plugins and builders - Updated `tsconfig.json` and `jest.config.js` to enable more consistent imports - Updated JS, TS, and TSX files with the above changes - Removed stale ESLint directives - Updated configurations, and code to ensure tests now pass where they were failing due to breaking changes to libraries - Updated configurations, and code to allow Webpack build to succeed
Also modified code to ensure that build is successful
If it ain't broke!
- Created JQuery plugin for graphs to aid with extensibility - Removed JQPlot - Removed scatter chart as this appeared to only be a line chart with a different name - Removed metrics as this feature appeared not to work and it's use-case is unknown
- Fix for dashboard graphs not working - Updated code to allow more options with the JQuery plugin - Reformatted code for all "new" graph functionality
- Removed "odd" and deprecated code - Removed transitions as these were causing issues with DataTables - Stopped Audit table being responsive and therefore allowing overflow to display regardless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires merge of #509 before merging