Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for chronology on curvals [B:1783] #523

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

droberts-ctrlo
Copy link
Contributor

This fix means the curvals will stop showing as added or removed when they "drop off" the view due to view limits.

@droberts-ctrlo droberts-ctrlo changed the base branch from master to dev March 10, 2025 16:29
@droberts-ctrlo droberts-ctrlo changed the title Fix for chronology on curvals Fix for chronology on curvals [B:1783] Mar 10, 2025
@abeverley
Copy link
Contributor

Good work. I think it might actually be possible to retrieve the chronology value from the record object, which could make this even lighter touch. Can you try testing $self->record->chronology within GADS::Datum::Curcommon::_build_all_ids?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants