Skip to content

Fix ItemSerializer n+1 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyeslattery merged 2 commits into from
Sep 12, 2025
Merged

Fix ItemSerializer n+1 #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f68f36b
fix n+1 in ItemSerializer
skyeslattery Sep 9, 2025
2eeff7e
Merge pull request #112 from cuappdev/skye/slow-load-fix
skyeslattery Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/item/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ class ItemSerializer(serializers.ModelSerializer):

def get_dietary_preferences(self, obj):
"""Get list of dietary preference names"""
return list(obj.dietary_preferences.values_list('name', flat=True))
return [pref.name for pref in obj.dietary_preferences.all()]

def get_allergens(self, obj):
"""Get list of allergen names"""
return list(obj.allergens.values_list('name', flat=True))
return [allergen.name for allergen in obj.allergens.all()]

def create(self, validated_data):
dietary_prefs = validated_data.pop('dietary_preferences', [])
Expand Down
Loading