-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(schema-compiler): Fix pre-agg matching for 'rollupJoin' / 'rollupLambda' pre-aggregations #10017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
8e58477
to
094dd8b
Compare
094dd8b
to
76fe519
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10017 +/- ##
===========================================
- Coverage 83.34% 48.90% -34.44%
===========================================
Files 244 196 -48
Lines 74032 15868 -58164
Branches 0 3103 +3103
===========================================
- Hits 61701 7761 -53940
+ Misses 12331 7719 -4612
- Partials 0 388 +388
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
42cda6b
to
48b1d14
Compare
…Lambda' pre-aggregations
48b1d14
to
a90cdee
Compare
a90cdee
to
0304b5c
Compare
This PR fixes incorrect pre-agg matching in case of 'rollupJoin' / 'rollupLambda' pre-aggs
Check List