Skip to content

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Sep 30, 2025

This PR fixes incorrect pre-agg matching in case of 'rollupJoin' / 'rollupLambda' pre-aggs

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

@KSDaemon KSDaemon force-pushed the fix/rollup-join-match branch from 8e58477 to 094dd8b Compare September 30, 2025 15:20
@KSDaemon KSDaemon marked this pull request as ready for review September 30, 2025 17:01
@KSDaemon KSDaemon requested a review from a team as a code owner September 30, 2025 17:01
@KSDaemon KSDaemon force-pushed the fix/rollup-join-match branch from 094dd8b to 76fe519 Compare October 15, 2025 18:22
@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 48.48485% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.90%. Comparing base (6523074) to head (12a58aa).

Files with missing lines Patch % Lines
...ejs-schema-compiler/src/adapter/PreAggregations.ts 52.45% 29 Missing ⚠️
...bejs-schema-compiler/src/compiler/CubeEvaluator.ts 0.00% 5 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6523074) and HEAD (12a58aa). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6523074) HEAD (12a58aa)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10017       +/-   ##
===========================================
- Coverage   83.34%   48.90%   -34.44%     
===========================================
  Files         244      196       -48     
  Lines       74032    15868    -58164     
  Branches        0     3103     +3103     
===========================================
- Hits        61701     7761    -53940     
+ Misses      12331     7719     -4612     
- Partials        0      388      +388     
Flag Coverage Δ
cube-backend 48.90% <48.48%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the fix/rollup-join-match branch 2 times, most recently from 42cda6b to 48b1d14 Compare October 20, 2025 20:08
@KSDaemon KSDaemon force-pushed the fix/rollup-join-match branch from 48b1d14 to a90cdee Compare October 21, 2025 12:42
@KSDaemon KSDaemon requested a review from a team as a code owner October 21, 2025 12:42
@KSDaemon KSDaemon force-pushed the fix/rollup-join-match branch from a90cdee to 0304b5c Compare October 21, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants