Skip to content

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds passing span_id to create_logical_plan function, allowing implementors of QueryEngine to log events in create_logical_plan implementation.

@MazterQyou MazterQyou requested a review from a team as a code owner October 13, 2025 16:21
@github-actions github-actions bot added the rust Pull requests that update Rust code label Oct 13, 2025
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.10%. Comparing base (070e6e0) to head (ed0b688).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10056       +/-   ##
===========================================
+ Coverage   48.81%   77.10%   +28.29%     
===========================================
  Files         196      440      +244     
  Lines       15787    89272    +73485     
  Branches     3099     3099               
===========================================
+ Hits         7706    68836    +61130     
- Misses       7692    20047    +12355     
  Partials      389      389               
Flag Coverage Δ
cube-backend 48.81% <ø> (ø)
cubesql 83.18% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MazterQyou MazterQyou merged commit 42c68da into master Oct 14, 2025
85 of 88 checks passed
@MazterQyou MazterQyou deleted the cubesql/pass-span-id branch October 14, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants