feat(gateway): return usedPreAggregations even in prod #9055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
flochaz
force-pushed
the
returnUsedPreAggregation
branch
from
27d5942 to
5d89ccd
Compare
|
Hi @flochaz 👋 Thanks for the contribution. Could you please explain what are you trying to achieve with this change? What is your use case? |
igorlukanin
reviewed
Jan 8, 2025
| ARG DEV_BUILD_IMAGE=cubejs/cube:build | ||
| ARG DEV_BUILD_IMAGE=cubejs/cube:dev |
There was a problem hiding this comment.
I wonder why is this change needed.
There was a problem hiding this comment.
After quick search — it seems that we do not produce cubejs/cube:build tags anymore, so I think that one was just missed. So it is ok!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
#9078
Description of Changes Made (if issue reference is not provided)
We are heavily relying on pre-aggregation and relying on job API to force rebuilt of pre aggregation.
The API support cubes or preAggregation parameter but there is no way to know what cube or preAggregation is used by a given query