-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cubesql): Fix SELECT DISTINCT on pushdown #9144
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9144 +/- ##
==========================================
+ Coverage 83.34% 83.39% +0.04%
==========================================
Files 227 227
Lines 81062 81323 +261
==========================================
+ Hits 67560 67818 +258
- Misses 13502 13505 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
62aefac
to
b9cf2bb
Compare
f326180
to
3316caf
Compare
84fdb24
to
b69b1a1
Compare
81ba359
to
0e6adb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One major issue is queries like this: SELECT DISTINCT * FROM cube1 JOIN cube2 ON cube1.__cubeJoinField = cube2.__cubeJoinField
. Both cubes have to be dimensions-only.
Other comments - just nitpicking
e22bbe7
to
ef28dc7
Compare
This PR fixes correct Cube query generation for
SELECT DISTINCT xxxx
queries via SQL API.Check List