fix(query-orchestrator): QueryCache - propagate error later for streams #9891
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr:community
|
Hi @igorlukanin, i'm not sure that this approach is the best way. Could you summon someone to review this? |
|
@ovr WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source (rowStream) emits an error or closes before all data is read, pipeline will reject.
This manually consumes the async iterator from the stream, catching errors at each step. If the stream ends early or throws, you catch the error and can handle it gracefully. This avoids some of the internal state issues that can occur with pipeline when the source stream is an async generator that may throw.
#9566