Show trades which share a cooldown if applicable.#18
Closed
cubefury wants to merge 213 commits intocubefury:masterfrom
Closed
Show trades which share a cooldown if applicable.#18cubefury wants to merge 213 commits intocubefury:masterfrom
cubefury wants to merge 213 commits intocubefury:masterfrom
Conversation
… a removed tradegroup.
Adjust tab pixels
Structure changes
Update zh_CN.lang
…ndices for NBT arrays. This change ensures that changelogs won't be massive every time a new trade is added, from all the tradegroups and their indices getting shuffled around.
Updated save format
Localize textures and gui title
Qol toggles
Change README
Changes:
Added Color settings for VM displayed text
Added small icon next to name of tradeable item
Shifted text color setting to lang file
Refactor trade state tracking into TradeManager
Fix potential NPE crash from bad trade request with invalid tradegroup.
Registry Name Migration for NewHorizonsCoreMod
Hot database reload
* Add incomplete structure message * Remove trades if incomplete structure.
* fix * fix for the fix
…destate (#66) * Check if player is not accessing vending machine before allowing trade state reload. * Grammar is hard
* swap out deprecated method * Remove unnecessary logic from coin eject buttons * Add favourites feature * Added saveload logic for favourites. * Add favourite toggle hint * Reset view to all items when favourites tab is empty * Fix serverside crash * spotless * Push favourited trades to the top in smart compare sort mode * Increased margins for tile display to stop console spam * spotless * Add placeholder icons * Remove unnecessary comments * Remove pair util class * Add favourites priority in both sort modes. * Removed delay between when ctrl released and tab switching when favourites are emptied. * Added preemptive favourites clearing when attemping to load from file, in case directory goes missing somehow when switching worlds * remove unnecessary pendingworldinit variable * Address comments * sanitize filenames to remove illegal characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights trades which share a cooldown, and added a tooltip to show how many trades the selected one shares a cooldown with, if applicable.
Showcase:
https://github.com/user-attachments/assets/271b5005-7190-4e83-b3d6-30347d48e01f
Tested in SP + MP daily 428