Skip to content

fix: resolve 5 code review issues (#29-33) - #34

Merged
yeongseon merged 1 commit into
mainfrom
fix/code-review-issues
Jul 23, 2026
Merged

fix: resolve 5 code review issues (#29-33)#34
yeongseon merged 1 commit into
mainfrom
fix/code-review-issues

Conversation

@yeongseon

Copy link
Copy Markdown
Contributor

Summary

Issue Severity Fix
#29 P0 Add security warning comments to f-string SQL in pandas recipes
#30 P1 Replace deprecated datetime.utcnow() across 22 files
#31 P1 Add future imports to recipes 07-10; replace getattr hack with direct pycubrid.connect()
#32 P2 Add cross-reference comment to duplicate recipe
#33 P1 Add routes/categories.py; add eager loading to ItemRepository; remove passive_deletes

Test Plan

  • All files compile cleanly (py_compile)

- #29 [P0] Add security warnings to f-string SQL in pandas recipes
- #30 [P1] Replace deprecated datetime.utcnow() across 22 files
- #31 [P1] Fix quality regression: add future imports, remove getattr hack
- #32 [P2] Add cross-reference to duplicate recipe
- #33 [P1] Complete FastAPI template: add category routes, eager loading, fix passive_deletes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant