ci: upstream-release smoke tests + pin ruff lint selection - #35
Merged
Conversation
…d version logging
CLOB rendering now preserves line-continuation markers and the README/ License char counts shifted (64->66, 46->47); Copyright is cubrid-lab. Reflection now lists the FK on cookbook_ref_articles and no longer emits the FK-backed index as a separate index row. Remove the temporary golden-dump step used to regenerate these files.
Set [tool.ruff.lint] select = ["E4","E7","E9","F"] (ruff's pre-0.16 default) so ruff version bumps stop surfacing hundreds of unrelated new-rule violations in CI. Remove 16 genuinely-unused imports flagged by F401, drop dead Base/engine import in the saga recipe, and settle ruff format under 0.16.2. Matches the pin adopted in pycubrid #248 and sqlalchemy-cubrid #272.
yeongseon
changed the title
- Route the untrusted repository_dispatch payload through env vars and
printf instead of inline ${{ }} shell interpolation, closing a
command-injection vector in the trigger-report step.
- Add an external pycubrid connectivity retry before make verify: the
in-container csql check does not prove the mapped broker port is
serving external clients, so the first example could race the broker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a smoke-test workflow so that new releases of pycubrid, sqlalchemy-cubrid, and cubrid-mcp-server automatically run the cookbook's example suite, and clears the blockers that kept that suite from passing deterministically.
What's included
.github/workflows/smoke-test.yml) triggered by upstream releases (repository_dispatch: upstream-released), daily cron, PRs, and manual dispatch.make verifyis stable:errno/sqlstatesuffix out of example output.pandas/matplotlibin CI for the batch-etl templates.csqlhealthcheck for reliable CUBRID readiness.06_loband06_reflectionto match current CLOB rendering and reflection output.[tool.ruff.lint] select = ["E4","E7","E9","F"](ruff's pre-0.16 default) so routine ruff bumps stop breakinglint-python, plus 16 F401 removals and aruff formatpass under 0.16.2. Same pin adopted in pycubrid #248 and sqlalchemy-cubrid #272.Supersedes #36 (the lint pin is folded in here because #35 and #36 could not pass CI independently — #35 needed the pin for
lint-python, #36 needed #35's smoke fixes forverify).Verification
All checks green:
lint-python,verify(full smoke, all examples pass), and Documentation lint. Localruff check .andruff format --check .pass with ruff 0.16.2.