ci: apply least-privilege token to smoke-test workflow - #41
Merged
Conversation
Add an explicit read-only permissions block and disable checkout credential persistence so the untrusted PR example code run by `make verify` cannot reach a write-scoped GITHUB_TOKEN. Closes #40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions: contents: readblock to theSmoke Testsworkflow (was inheriting the repo defaultwritetoken).persist-credentials: falseonactions/checkoutsoGITHUB_TOKENis not stored in.git/config.Why
make verifyexecutes untrusted PR-authored example.pyfiles. With the default write token persisted into.git/config, that code could read the token and push to the repo or approve PRs. Read-only + no credential persistence closes this escalation path. No secrets are referenced by the workflow, so functionality is unaffected.Closes #40